Skip to content

configure support for extended test suite #187

New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom
Merged
merged 1 commit into from
Nov 9, 2016
Merged

configure support for extended test suite #187

merged 1 commit into from
Nov 9, 2016

Conversation

dgrove-oss
Copy link
Contributor

Add a configure argument to enable extended test suite.
The extended test suite is disabled by default (and thus
will not be run in vanilla Swift CI jobs).

Move yet another intermittently failing test,
dispatch_suspend_timer, out of the list of default tests.

@dgrove-oss
configure support for extended test suite
bf3c07a 
Add a configure argument to enable extended test suite.
The extended test suite is disabled by default (and thus
will not be run in vanilla Swift CI jobs).

Move yet another intermittently failing test,
dispatch_suspend_timer, out of the list of default tests.
@dgrove-oss
Copy link
Contributor Author

@erg: in response to email-chain on swift-dev about dispatch_suspend_timer disturbing Swift CI.

@erg
Copy link
Contributor

erg commented Nov 7, 2016 •
edited
Loading

Each Linux Jenkins CI box runs two executors each with 50% of the CPU resources. I found a utility called stress that will max out the cores on a machine. It's installable through brew install stress or from https://people.seas.harvard.edu/~apw/stress/.

If the dispatch tests pass while run in a loop for a few minutes with stress --cpu 8 --timeout 6000 (where 8 is the max cores for your machine) then that should be good enough to ensure they pass on the CI machine.

The problem with this patch is I would want to disable these tests for PR testing (really only the dispatch_suspend_timer test is breaking things now), but keep them enabled for everything else so we don't have regressions in libdispatch as you suggested in the email thread.

What do you think?

@erg erg merged commit 92773e0 into swiftlang:master Nov 9, 2016
@erg
Copy link
Contributor

erg commented Nov 9, 2016

Actually, looks good since it's just a few more flaky tests. It would be nice to make them all reliable somehow and reenable them.

Thank you!

@erg
Copy link
Contributor

erg commented Nov 9, 2016 •
edited
Loading

Could also please do a PR with this change to swift-3.0-branch? Thanks!

@dgrove-oss
Copy link
Contributor Author

Sure, I'll get a Swift 3 branch PR together later this afternoon.

@dgrove-oss dgrove-oss mentioned this pull request Nov 10, 2016
Merged
@dgrove-oss dgrove-oss deleted the extended-test-suite branch November 18, 2016 15:16
das pushed a commit that referenced this pull request Feb 21, 2017
@erg @das
Merge pull request #187 from dgrove-oss/extended-test-suite
5c3faa9 
configure support for extended test suite

Signed-off-by: Daniel A. Steffen <dsteffen@apple.com>
This was referenced Nov 3, 2016
Closed
Closed
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers
No reviews
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@dgrove-oss @erg @das @MadCoder